Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] ViP Market: last minors #7250

Merged
merged 7 commits into from
Feb 20, 2025
Merged

🎨 [Frontend] ViP Market: last minors #7250

merged 7 commits into from
Feb 20, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 20, 2025 •
edited
Loading

What do these changes do?

  • List of model in the bundle
    • Update label composition: ${name}, ${functionality} -> ${name} ${version}, ${functionality}
    • Make the whole thing clickable and show pointer cursor
  • Add white spaces every 3 digits in amount of cost credits
  • Keep model's details size when switching models within bundle
  • Select "My Models" by default

2002

Bonus

  • Fix dynmic-schdlr in devel mode (WSL)

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Feb 20, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Feb 20, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 20, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (9d6f156) to head (7bd7750).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7250      +/-   ##
==========================================
+ Coverage   87.07%   87.14%   +0.06%     
==========================================
  Files        1679     1671       -8     
  Lines       64869    64638     -231     
  Branches     1115     1115              
==========================================
- Hits        56486    56328     -158     
+ Misses       8065     7992      -73     
  Partials      318      318
Flag Coverage Δ
integrationtests 65.46% <ø> (+0.03%) ⬆️
unittests 86.14% <ø> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.17% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.54% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.28% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.61% <ø> (ø)
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.08% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.56% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.19% <ø> (+0.32%) ⬆️
storage 86.67% <ø> (+0.05%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.09% <ø> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6f156...7bd7750. Read the comment docs.

@odeimaiz odeimaiz marked this pull request as ready for review February 20, 2025 10:50
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: 20 02 🎨 [Frontend] ViP Market: last minors Feb 20, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz enabled auto-merge (squash) February 20, 2025 10:56
mrnicegyu11
mrnicegyu11 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thx

pcrespov
pcrespov reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit d5072d0 into ITISFoundation:master Feb 20, 2025
94 checks passed
@odeimaiz odeimaiz deleted the enh/20-02 branch February 20, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@mguidon mguidon Awaiting requested review from mguidon

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @mrnicegyu11 @pcrespov @sanderegg @YuryHrytsuk